Updated str endpoint for other Azure Envs#30
Open
kenrward wants to merge 1 commit intoAzure-Samples:dev-masterfrom
Open
Updated str endpoint for other Azure Envs#30kenrward wants to merge 1 commit intoAzure-Samples:dev-masterfrom
kenrward wants to merge 1 commit intoAzure-Samples:dev-masterfrom
Conversation
|
Thanks for contributing @kenrward ! We'll get this tested out and merged asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team, I have no way to test this since I don't have access to an EA but I updated this to hopefully work in Azure Gov, Azure China, etc. You hardcoded str endpoints for Azure Commercial and all I did was use powershell to get the primaryendpoint blob of the storage account instead of hardcoding. This should allow government customers to use it. Let me know if you wish to discuss further.
ken